[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

Tue Oct 8 11:44:32 PDT 2019

thakis accepted this revision.
thakis added a comment.

lgtm. I finally got around to understanding the patch. Sorry for the delay, thanks for the fix! Next time you upload a patch, please upload it with more context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

Note to self: The mangleSourceName() call mentioned in the patch description is 14 lines further up. `mangleSourceName(TemplateMangling);` outputs the number if there's a backref, else it outputs the argument followed by a '@'. Since we only cache mangleSourceName()'s argument, we need to append '@' ourselves. It seems a tiny bit nicer to store the '@' in the cache, but as-is is fine too.

Do you need someone to commit this for you?

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68099/new/

https://reviews.llvm.org/D68099