[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

> Can you clarify what exactly the TODO is? As-is, the check suggests removing the redeclaration where it's a no-op (non-ms) but not where it isn't (C, ms compat). If I understand your reply correctly, this is desired behavior. Is the TODO then to have test coverage for the ms compat case? If so: Can clang-tidy checks have different CHECK-MESSAGES suffixes in the same file? If so, we can just run the test once with -fms-compat and once with -fno-ms-compat and expect the diag in one case and not in the other.

To answer my question: https://clang.llvm.org/extra/clang-tidy/Contributing.html#testing-checks explains how to do this. I'll update the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68640/new/

https://reviews.llvm.org/D68640