[PATCH] D33029: [clang-format] add option for dangling parenthesis

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

I tried the patch and rebased it locally (as there were conflicts with the current trunk)

The change caused other tests to fail (which doesn't completely surprise me)

most tests failures look associated with positioning of trailing brace for example

  @@ -1,4 +1,4 @@
   void f() {
     bar([]() {} // Did not respect SpacesBeforeTrailingComments
  -  );
  + );
   }

Below is a list of the tests that fail

  [==========] 700 tests from 21 test cases ran. (6687 ms total)
  [  PASSED  ] 692 tests.
  [  FAILED  ] 8 tests, listed below:
  [  FAILED  ] FormatTest.WrapsTemplateDeclarations
  [  FAILED  ] FormatTest.BreaksStringLiteralsWithin_TMacro
  [  FAILED  ] FormatTest.FormatsLambdas
  [  FAILED  ] FormatTest.WrappedClosingParenthesisIndent
  [  FAILED  ] FormatTestJS.FunctionParametersTrailingComma
  [  FAILED  ] FormatTestJS.FunctionLiterals
  [  FAILED  ] FormatTestJS.ArrowFunctions
  [  FAILED  ] FormatTestJS.NestedLiterals
  
   8 FAILED TESTS


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33029/new/

https://reviews.llvm.org/D33029