[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

[Nico Weber via Phabricator via cfe-commits]

thakis created this revision.
thakis added a reviewer: rnk.
thakis added a comment.

There's just one other use of `-fno-ms-compatibility` in clang-tidy's test suite, so I'm not 100% sure this is the way to go. It's better than disabling the test completely on Windows :)


In MS compatibility mode, "extern inline void g()" is not a redundant
declaration for "inline void g()", because of redeclForcesDefMSVC()
(see PR19264, r205485).

To fix, just run the test with -fno-ms-compatibility.

Final bit of PR43593.


https://reviews.llvm.org/D68640

Files:
  clang-tools-extra/test/clang-tidy/readability-redundant-declaration.cpp


Index: clang-tools-extra/test/clang-tidy/readability-redundant-declaration.cpp
===================================================================
--- clang-tools-extra/test/clang-tidy/readability-redundant-declaration.cpp
+++ clang-tools-extra/test/clang-tidy/readability-redundant-declaration.cpp
@@ -1,7 +1,7 @@
 // RUN: %check_clang_tidy %s readability-redundant-declaration %t -- \
 // RUN:   -config="{CheckOptions: \
 // RUN:             [{key: readability-redundant-declaration.IgnoreMacros, \
-// RUN:               value: 0}]}"
+// RUN:               value: 0}]}" -- -fno-ms-compatibility
 
 extern int Xyz;
 extern int Xyz; // Xyz


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68640.223843.patch
Type: text/x-patch
Size: 642 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191008/deddb233/attachment.bin>