[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

Tue Oct 8 01:51:23 PDT 2019

ilya-biryukov added a comment.

In D67536#1697825 <https://reviews.llvm.org/D67536#1697825>, @sammccall wrote:

> So I don't think clients will/should prefer that - for best rendering they should know this is a line highlight.

I have actually seen clients that just make the text gray and it looks pretty nice (ReSharper for Visual Studio and IntelliJ IDEA definitely do that).
It also lets them consistently highlight part of the line (e.g. dead expressions or statements can be marked in gray even if they are on the same line).

So I wouldn't be so sure, at least some clients might prefer to do exclusively range (as opposed to line-based) highlightings.

PS Sorry if this was discussed before and I'm just missing context.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536