[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

Mon Oct 7 17:45:07 PDT 2019

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Thanks!!

================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2030-2033
     // FIXME: this is a hack for fixing a later crash when attempting to
     // dereference a void* pointer.
     // We should not try to dereference pointers at all when we don't care
     // what is written inside the pointer.
----------------
Aha, so you're basically propagating this FIXME instead of addressing it. When it was originally added, i vaguely recall that the pointer that we were trying to dereference did not really need to be tracked to begin with. I'm really curious if that's still the case in this example.

================
Comment at: clang/test/Analysis/novoidtypecrash.c:1
 // RUN: %clang_analyze_cc1 -analyzer-checker=core %s
+x;
----------------
So does the warning get actually emitted, or is it marked as invalid? Maybe it's worth it to add `-verify` (and maybe even `-analyzer-output=text`) and assess how good the report actually is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68591/new/

https://reviews.llvm.org/D68591