r373928 - [libTooling][NFC] Fix build break in r373916.

Yitzhak Mandelbaum via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 7 10:24:23 PDT 2019


Author: ymandel
Date: Mon Oct  7 10:24:23 2019
New Revision: 373928

URL: http://llvm.org/viewvc/llvm-project?rev=373928&view=rev
Log:
[libTooling][NFC] Fix build break in r373916.

r373916 used raw strings inside macro calls, which breaks some builds.

Modified:
    cfe/trunk/unittests/Tooling/StencilTest.cpp

Modified: cfe/trunk/unittests/Tooling/StencilTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/StencilTest.cpp?rev=373928&r1=373927&r2=373928&view=diff
==============================================================================
--- cfe/trunk/unittests/Tooling/StencilTest.cpp (original)
+++ cfe/trunk/unittests/Tooling/StencilTest.cpp Mon Oct  7 10:24:23 2019
@@ -392,56 +392,64 @@ TEST(StencilEqualityTest, InEqualityRun)
 
 TEST(StencilToStringTest, RawTextOp) {
   auto S = cat("foo bar baz");
-  EXPECT_EQ(S.toString(), R"("foo bar baz")");
+  StringRef Expected = R"("foo bar baz")";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, RawTextOpEscaping) {
   auto S = cat("foo \"bar\" baz\\n");
-  EXPECT_EQ(S.toString(), R"("foo \"bar\" baz\\n")");
+  StringRef Expected = R"("foo \"bar\" baz\\n")";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, DebugPrintNodeOp) {
   auto S = cat(dPrint("Id"));
-  EXPECT_EQ(S.toString(), R"repr(dPrint("Id"))repr");
+  StringRef Expected = R"repr(dPrint("Id"))repr";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, ExpressionOp) {
   auto S = cat(expression("Id"));
-  EXPECT_EQ(S.toString(), R"repr(expression("Id"))repr");
+  StringRef Expected = R"repr(expression("Id"))repr";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, DerefOp) {
   auto S = cat(deref("Id"));
-  EXPECT_EQ(S.toString(), R"repr(deref("Id"))repr");
+  StringRef Expected = R"repr(deref("Id"))repr";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, AddressOfOp) {
   auto S = cat(addressOf("Id"));
-  EXPECT_EQ(S.toString(), R"repr(addressOf("Id"))repr");
+  StringRef Expected = R"repr(addressOf("Id"))repr";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, AccessOp) {
   auto S = cat(access("Id", text("memberData")));
-  EXPECT_EQ(S.toString(), R"repr(access("Id", "memberData"))repr");
+  StringRef Expected = R"repr(access("Id", "memberData"))repr";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, AccessOpStencilPart) {
   auto S = cat(access("Id", access("subId", "memberData")));
-  EXPECT_EQ(S.toString(),
-            R"repr(access("Id", access("subId", "memberData")))repr");
+  StringRef Expected = R"repr(access("Id", access("subId", "memberData")))repr";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, IfBoundOp) {
   auto S = cat(ifBound("Id", text("trueText"), access("exprId", "memberData")));
-  EXPECT_EQ(
-      S.toString(),
-      R"repr(ifBound("Id", "trueText", access("exprId", "memberData")))repr");
+  StringRef Expected =
+      R"repr(ifBound("Id", "trueText", access("exprId", "memberData")))repr";
+  EXPECT_EQ(S.toString(), Expected);
 }
 
 TEST(StencilToStringTest, MultipleOp) {
   auto S = cat("foo", access("x", "m()"), "bar",
                ifBound("x", text("t"), access("e", "f")));
-  EXPECT_EQ(S.toString(), R"repr("foo", access("x", "m()"), "bar", )repr"
-                          R"repr(ifBound("x", "t", access("e", "f")))repr");
+  StringRef Expected = R"repr("foo", access("x", "m()"), "bar", )repr"
+                       R"repr(ifBound("x", "t", access("e", "f")))repr";
+  EXPECT_EQ(S.toString(), Expected);
 }
 } // namespace




More information about the cfe-commits mailing list