[PATCH] D68535: Fix loop unrolling initialization in the new pass manager
Alina Sbirlea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 7 09:36:31 PDT 2019
asbirlea added a comment.
Maybe elaborate in the patch description what `determine when and how we will unroll loops.` means?
e.g.:
"The default before and after this patch is for LoopUnroll to be enabled, and for it to use a cost model to determine whether to unroll the loop (`OnlyWhenForced = false`). Before this patch, disabling loop unroll would not run the LoopUnroll pass. After this patch, the LoopUnroll pass is being run, but it restricts unrolling to only the loops marked by a pragma (`OnlyWhenForced = true`).
In addition, this patch disables the UnrollAndJam pass when disabling unrolling."
Otherwise LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68535/new/
https://reviews.llvm.org/D68535
More information about the cfe-commits
mailing list