[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers
Dávid Bolvanský via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 7 09:06:26 PDT 2019
xbolva00 added a comment.
@tkanis wrote in post commit review:
“What do you think about also not emitting the warning if the lhs sizeof is an array of signed or unsigned char? The warning wants the rhs sizeof to be sizeof(char) which is 1, and dividing by that doesn't really make sense. ”
I agree with him. I think you can land this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68526/new/
https://reviews.llvm.org/D68526
More information about the cfe-commits
mailing list