[PATCH] D68584: Fix Calling Convention through aliases

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 7 08:46:55 PDT 2019


erichkeane created this revision.
erichkeane added reviewers: rnk, pcc.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

r369697 changed the behavior of stripPointerCasts to no longer include
aliases.  However, the code in CGDeclCXX.cpp's createAtExitStub counted
on the looking through aliases to properly set the calling convention of
a call.

      

The result of the change was that the calling convention mismatch of the
call would be replaced with a llvm.trap, causing a runtime crash.


https://reviews.llvm.org/D68584

Files:
  clang/lib/CodeGen/CGDeclCXX.cpp
  clang/test/CodeGenCXX/call-conv-thru-alias.cpp
  llvm/include/llvm/IR/Value.h
  llvm/lib/IR/Value.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68584.223617.patch
Type: text/x-patch
Size: 4052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191007/74ab1256/attachment.bin>


More information about the cfe-commits mailing list