[PATCH] D68565: [clang] Add test for FindNextToken in Lexer.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 7 04:49:44 PDT 2019
ilya-biryukov added a comment.
Could you add a rationale in the change description? E.g. something like `we do not have any tests for findNextToken`
================
Comment at: clang/unittests/Lex/LexerTest.cpp:559
+ }
+ EXPECT_EQ(ExpectedTokens, GeneratedByNextToken);
+}
----------------
NIT: could be replaced with
```
EXPECT_THAT(GeneratedByNextToken, ElementsAre("abcd", "=", ....))
```
To avoid creating an extra variable.
But up to you, this version also looks ok.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68565/new/
https://reviews.llvm.org/D68565
More information about the cfe-commits
mailing list