r373895 - [ASTImporter][NFC] Update ASTImporter internals docs

Gabor Marton via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 7 04:15:18 PDT 2019


Author: martong
Date: Mon Oct  7 04:15:18 2019
New Revision: 373895

URL: http://llvm.org/viewvc/llvm-project?rev=373895&view=rev
Log:
[ASTImporter][NFC] Update ASTImporter internals docs

Modified:
    cfe/trunk/docs/InternalsManual.rst

Modified: cfe/trunk/docs/InternalsManual.rst
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/InternalsManual.rst?rev=373895&r1=373894&r2=373895&view=diff
==============================================================================
--- cfe/trunk/docs/InternalsManual.rst (original)
+++ cfe/trunk/docs/InternalsManual.rst Mon Oct  7 04:15:18 2019
@@ -1519,11 +1519,11 @@ statements are true:
 - A and X are nodes from the same ASTContext.
 - B and Y are nodes from the same ASTContext.
 - A and B may or may not be from the same ASTContext.
-- if A == X (pointer equivalency) then (there is a cycle during the traverse)
+- if A == X and B == Y (pointer equivalency) then (there is a cycle during the
+  traverse)
 
   - A and B are structurally equivalent if and only if
 
-    - B and Y are part of the same redeclaration chain,
     - All dependent nodes on the path from <A,B> to <X,Y> are structurally
       equivalent.
 
@@ -1563,15 +1563,6 @@ the whole redeclaration chain of the fun
 declarations - regardless if they are definitions or prototypes - in the order
 as they appear in the "from" context.
 
-.. Structural eq requires proper redecl chains
-
-Another reason why we must maintain and import redeclaration chains properly is
-that the :ref:`Structural Equivalency <structural-eq>` check would report false
-positive in-equivalencies otherwise. We must not allow having two (or more)
-independent redeclaration chains of structurally equivalent declarations.
-Structural equivalency identifies the chains with the canonical declaration,
-that becomes different for independent chains.
-
 .. One definition
 
 If we have an existing definition in the "to" context, then we cannot import




More information about the cfe-commits mailing list