[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

Andrew Paverd via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 4 01:35:13 PDT 2019


ajpaverd added a comment.

In D65761#1660121 <https://reviews.llvm.org/D65761#1660121>, @rnk wrote:

> Here is some feedback, I apologize for dragging my feet.
>
> Also, I would really like to get feedback from @pcc. He's OOO currently, though.


Thanks for this really helpful feedback @rnk! I think I've been able to address most of your comments in the latest update. Your suggested approach of using operand bundles for the dispatch mechanism instead of changing calling conventions works well and makes the design a lot cleaner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65761/new/

https://reviews.llvm.org/D65761





More information about the cfe-commits mailing list