[PATCH] D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers
Balogh, Ádám via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 4 01:11:51 PDT 2019
baloghadamsoftware added a comment.
In D67336#1664168 <https://reviews.llvm.org/D67336#1664168>, @NoQ wrote:
> I have mixed feelings. Removing boilerplate is good, but the very fact that we're legalizing this pattern indicates that our checkers will keep bloating up, while i always wanted to actually split them instead (like, make sub-checkers into their own separate //classes//, possibly spread out into different files, kinda micro checkers as opposed to monolithic checkers (?)). But i guess it's about whoever gets things done first :)
I completely agree with you about splitting the checkers. I also plan for the iterator checkers to separate them from the modelling and make a few mini checker classes beside the still huge modelling class. I am confident that that is the right direction.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67336/new/
https://reviews.llvm.org/D67336
More information about the cfe-commits
mailing list