[PATCH] D68377: [Builtins] Teach Clang about memccpy

Thu Oct 3 13:11:11 PDT 2019

aaron.ballman added a comment.

In D68377#1693490 <https://reviews.llvm.org/D68377#1693490>, @xbolva00 wrote:

>   It is not very obvious for me what kind of test should be done here. I would be grateful if you could show me an example in tree.

I was thinking of something in CodeGen, like CodeGen/builtin-memfns.c

> Exactly for -fno-builtin-memccpy case?

That would be another good test case.

================
Comment at: include/clang/Basic/Builtins.def:483
 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF")
+BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF")
 BUILTIN(__builtin_memmove, "v*v*vC*z", "nF")
----------------
xbolva00 wrote:
> aaron.ballman wrote:
> > GCC doesn't seem to have `__builtin_memccpy`? https://godbolt.org/z/jbthQ3
> Ok, I will drop it.
If you drop it, won't that lose the builtin? I was mostly thinking it's in the wrong part of the list of builtins.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68377/new/

https://reviews.llvm.org/D68377