[PATCH] D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA.

[Artem Belevich via Phabricator via cfe-commits]

tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/Driver.cpp:2538
+        : CudaActionBuilderBase(C, Args, Inputs, Action::OFK_Cuda) {
+      DefaultCudaArch = CudaArch::SM_20;
+    }
----------------
hliao wrote:
> tra wrote:
> > This technically depends on the CUDA version.
> > We do have CUDA version info in `clang/lib/Driver/ToolChains/Cuda.h`
> > The default for NVCC has been sm_30 since CUDA-9.0.  In fact sm_20 is not supported at all by CUDA-9.0+ at all , so we should bump the default to sm_30 for those versions.
> > 
> unfortunately, when the action build is running, the CUDA is not detected yet, I probably revise the detection logic to update CUDA's default gpu arch after successful detection
OK. If there's no easy way to do it here, it's probably not worth doing it just to keep sm_20 as the default.
sm_20 has not been supported by the last two major CUDA releases and it makes little sense to have the default that does not work for the majority of current users.

I think we should just bump the default to sm_30 for all currently supported CUDA versions in a separate patch. I can do it once this patch lands.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68394/new/

https://reviews.llvm.org/D68394