[PATCH] D68364: Prototype implementation of P0784R7: mark all members of std::allocator and std::allocator_traits as constexpr.

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

Thanks for doing this, Richard.
A few things:

- Needs tests (as you said)
- The config macro stuff is all wrong (we build that file from a template)
- Use `__libcpp_is_constant_evaluated` instead of `__builtin_is_constant_evaluated` because it doesn't have to be `#ifdef`ed. (see r364873 and r364884)
- If we're in a consteval block, we shouldn't be testing for exceptions being disabled, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68364/new/

https://reviews.llvm.org/D68364