[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

Sergey Dmitriev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 2 13:03:12 PDT 2019


sdmitriev added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:2284-2289
-    /// Append top level actions generated by the builder. Return true if errors
-    /// were found.
+    /// Append top level actions generated by the builder.
     virtual void appendTopLevelActions(ActionList &AL) {}
 
-    /// Append linker actions generated by the builder. Return true if errors
-    /// were found.
----------------
ABataev wrote:
> Could you fix these comments is a separate patch?
Sure. I will prepare a separate patch for the comment change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68166/new/

https://reviews.llvm.org/D68166





More information about the cfe-commits mailing list