[PATCH] D67031: [Clang][Bundler] Error reporting improvements
    Alexey Bataev via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Wed Oct  2 11:43:53 PDT 2019
    
    
  
ABataev added inline comments.
================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133
   /// returned if there are no more bundles to be read.
-  virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0;
+  virtual Expected<Optional<StringRef>>
+  ReadBundleStart(MemoryBuffer &Input) = 0;
----------------
Do we really need an inner `Optional` here?
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
    
    
More information about the cfe-commits
mailing list