[PATCH] D68300: [HIP] Add option -fno-link-builtin-bitcode to disable linking device lib

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: include/clang/Driver/Options.td:606
+def flink_builtin_bitcode : Flag<["-"], "flink-builtin-bitcode">,
+  Flags<[CC1Option]>, HelpText<"Link builtin bitcode for HIP device compilation.">;
+def fno_link_builtin_bitcode : Flag<["-"], "fno-link-builtin-bitcode">;
----------------
yaxunl wrote:
> ashi1 wrote:
> > Since this is a more generic approach, we won't need to specify HIP ?
> this patch only implemented this option for HIP. If it is used for other languages, this help text should be updated.
Hmm. Cuda currently uses `-nocudalib` for essentially the same purpose (Sort of like `-nostdlib`, but for CUDA). Perhaps we should consolidate all these into `-nogpulib` and alias `-nocudalib` to it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68300/new/

https://reviews.llvm.org/D68300