[PATCH] D68315: [libTooling] Add various Stencil combinators for expressions.

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149
 /// \returns the source corresponding to the selected range.
 StencilPart selection(RangeSelector Selector);
 
----------------
Should the comment cross-reference expression() and say that the user probably wants that instead?


================
Comment at: clang/lib/Tooling/Refactoring/Stencil.cpp:71
+// Generic container for stencil operations with a (single) node-id argument.
+struct OperationData {
+  OperationData(NodeOperator Op, std::string Id) : Op(Op), Id(std::move(Id)) {}
----------------
Add "unary" to the name somewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68315/new/

https://reviews.llvm.org/D68315