[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

Through experiments, I notice that both result and the Code contains "\r\n", because although we construct the results with "\n" the actual text of the include has I believe trailing "\r" or "\r\n", I notice this when I thought one fix I tried was to trim the include text.

``result += Imports[Index].Text.trim()```

However, this had the effect of dos2unixing the ```result``` and the include section of a windows file

but I take your point about the  "\r" without the "\r\n"

I'll change the code but I believe it will need to be

  if (stripNewlineCRs(result) == stripNewlineCRs(...))

I'll send an updated review


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68227/new/

https://reviews.llvm.org/D68227