[PATCH] D68211: [clangd] Use the index-based API to do the header-source switch.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

some nits, thanks!



================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:456
+  //  1) use the file-only heuristic, it requires some IO but it is much
+  //    faster than building AST, it works when .h/.cc files are in the same
+  //    directory.
----------------
AST, it works -> AST, but it only works


================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:456
+  //  1) use the file-only heuristic, it requires some IO but it is much
+  //    faster than building AST, it works when .h/.cc files are in the same
+  //    directory.
----------------
kadircet wrote:
> AST, it works -> AST, but it only works
indent one more column


================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:458
+  //    directory.
+  //  2) if 1) fails, we use the AST&Index approach, it is slower but works for
+  //     different code layout.
----------------
s/works for/supports


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68211/new/

https://reviews.llvm.org/D68211