[PATCH] D68024: [clangd] Implement GetEligiblePoints
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 30 07:54:53 PDT 2019
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/SourceCode.h:270
+ /// It will be “a::b” for both carrot locations.
+ std::string CurrentNamespace;
+ /// Offsets into the code marking eligible points to insert a function
----------------
ilya-biryukov wrote:
> Do we ever name anonymous namespace here? How do we represent them?
> Do we ever name anonymous namespace here? How do we represent them?
No we don't, represents anonymous namespaces. I also updated docs to mention that `FullyQualifiedName` should not contain anon namespaces.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68024/new/
https://reviews.llvm.org/D68024
More information about the cfe-commits
mailing list