[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 29 17:23:43 PDT 2019


nridge added a comment.

The updated patch formulates this as a new semantic highlighting kind.

The tokens created for inactive regions are one per line, with the character offset and length being zero; the idea is that the client will handle this highlighting specially (see D67537 <https://reviews.llvm.org/D67537>) and highlight the entire line.

Note, highlighting the entire line is different than highlighting just the portion of the line that contains text. We want the grey background highlight to extend to the entire row in the editor, even over columns beyond the end of the text line (as accomplished with vscode's `isWholeLine=true` option in `DecorationRenderOptions`).

I don't love special-casing the scope in the client, but this does avoid having to extend the protocol itself which would be considerably more work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536





More information about the cfe-commits mailing list