[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 27 14:01:28 PDT 2019


tejohnson added a comment.

Please upload patches with context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)

I'm not terribly familiar with this part of clang, but my concern would be that overriding the PresumedInputFile here could have unintended side effects. How about simply overriding the source file name on the Module object that eventually gets created, if it is "-"? I believe that is in the CodeGeneratorImpl constructor, and the CodeGenOptions are available there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67592/new/

https://reviews.llvm.org/D67592





More information about the cfe-commits mailing list