[PATCH] D68024: [clangd] Implement GetEligiblePoints
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 27 09:36:03 PDT 2019
kadircet marked an inline comment as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/SourceCode.h:270
+ /// It will be “a::b” for both carrot locations.
+ std::string CurrentNamespace;
+ /// Offsets into the code marking eligible points to insert a function
----------------
hokein wrote:
> `Current` seems not clear enough, how about "MatchNamespace"?
what about enclosing?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68024/new/
https://reviews.llvm.org/D68024
More information about the cfe-commits
mailing list