[PATCH] D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes.
Yitzhak Mandelbaum via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 27 08:20:05 PDT 2019
ymandel added a comment.
In D66652#1654585 <https://reviews.llvm.org/D66652#1654585>, @gribozavr wrote:
> > So, I plan to rework this into two revisions: one to match https://reviews.llvm.org/D66676 (and keep the tests esssentially as they are) and one to add getRuleMatchLoc for future use.
>
> That SGTM.
>
> I don't have an opinion about whether they should be separate revisions or not.
Reworked, per our discussion. I kept it in one revision, because I ended up useing the new function in this code (for error reporting).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66652/new/
https://reviews.llvm.org/D66652
More information about the cfe-commits
mailing list