[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

Fri Sep 27 02:30:31 PDT 2019

ilya-biryukov added a comment.

In D66647#1685506 <https://reviews.llvm.org/D66647#1685506>, @kadircet wrote:

> I actually have a fixme saying:
>
>   // FIXME: Instead of fully qualifying we should try deducing visible scopes at
>   // target location and generate minimal edits.
>
>
> Elaborating on it by saying "we can start by using the namespaces in targetcontext".

Are we planning to fix this right away or should we keep this indefinitely?
If latter, I believe we should think about some heuristics to avoid qualification in the short term instead.
If we want to do it right away, that's great! (albeit more complicated, I guess)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66647/new/

https://reviews.llvm.org/D66647