[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

I had a fix, but I was too slow. Here's what you need for the reland: http://codepad.org/3klmw1JV

The commit also broke sphinx with this:

  `
  6.290 [0/1/1] Generating html Sphinx documentation for clang-tools into "/home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/build/tools/clang/tools/extra/docs/html"
  FAILED: tools/clang/tools/extra/docs/CMakeFiles/docs-clang-tools-html 
  cd /home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/build/tools/clang/tools/extra/docs && /usr/bin/sphinx-build -b html -d /home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/build/tools/clang/tools/extra/docs/_doctrees-clang-tools-html -q -W /home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/src/tools/clang/tools/extra/docs /home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/build/tools/clang/tools/extra/docs/html
  
  Warning, treated as error:
  /home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/src/tools/clang/tools/extra/docs/ReleaseNotes.rst:82: WARNING: Inline interpreted text or phrase reference start-string without end-string.

Please try to fix that for the reland as well :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67567/new/

https://reviews.llvm.org/D67567