[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

[Puyan Lotfi via Phabricator via cfe-commits]

plotfi added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:3372
+      if (Phase == phases::IfsMerge) {
+        assert(Phase == PL.back() && "merging must be final compilation step.");
+        MergerInputs.push_back(Current);
----------------
compnerd wrote:
> Does the interface merging have to be the last step?  I could see interface merging preceding linking just fine.
For now I think that's the expedient thing to do. Do you want to change that?


================
Comment at: clang/test/InterfaceStubs/driver-test.cpp:17
+// CHECK-DAG: _Z8weakFuncv
+
+int foo(int bar) {
----------------
compnerd wrote:
> Should we not ensure that no other symbols are exported?
You mean like bar? 


================
Comment at: clang/test/InterfaceStubs/object.ifs:1
+# RUN: %clang -emit-merged-ifs -target x86_64-unknown-linux-gnu \
+# RUN: -emit-interface-stubs  -o - %s | \
----------------
compnerd wrote:
> Can we drop the target and get this to be portable?
Hmm, can we do unknown-unknown-linux-gnu? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63978/new/

https://reviews.llvm.org/D63978