[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 25 08:38:45 PDT 2019


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

@kadircet says we're using this pattern all over clangd. This somehow slipped my view before.
LGTM to be consistent with the rest of clangd (and functions in `FindTarget.h`).

I think we should switch to passing non-const pointers everywhere, but that's a discussion for another day...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68027/new/

https://reviews.llvm.org/D68027





More information about the cfe-commits mailing list