[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 25 07:37:29 PDT 2019


ABataev added a comment.

Definitely need positive tests with ast printing and codegen.



================
Comment at: lib/Sema/SemaOpenMP.cpp:14751
+    assert(Type->getAsArrayTypeUnsafe() && "Expect to get a valid array type");
+    Type = Type->getAsArrayTypeUnsafe()->getElementType().getCanonicalType();
+  }
----------------
Why do you want canonical type here? I think it is wrong. It drops all language sugar like typedefs etc. But typedefs are not supported in mappers, right?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67978/new/

https://reviews.llvm.org/D67978





More information about the cfe-commits mailing list