[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 25 06:54:45 PDT 2019
kadircet created this revision.
kadircet added reviewers: hokein, ilya-biryukov.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D68020
Files:
clang-tools-extra/clangd/SourceCode.cpp
clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
Index: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
+++ clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
@@ -423,6 +423,12 @@
)cpp",
{"bar", ""},
},
+ {
+ R"cpp(
+ // Parse until EOF
+ namespace bar{})cpp",
+ {""},
+ },
{
R"cpp(
// Namespaces with multiple chunks.
Index: clang-tools-extra/clangd/SourceCode.cpp
===================================================================
--- clang-tools-extra/clangd/SourceCode.cpp
+++ clang-tools-extra/clangd/SourceCode.cpp
@@ -659,6 +659,9 @@
while (!Lex.LexFromRawLexer(Tok))
A(Tok);
+ // LexFromRawLexer returns true after it lexes last token, so we still have
+ // one more token to report.
+ A(Tok);
}
llvm::StringMap<unsigned> collectIdentifiers(llvm::StringRef Content,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68020.221752.patch
Type: text/x-patch
Size: 991 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190925/45d1f3d5/attachment.bin>
More information about the cfe-commits
mailing list