[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102
 // expected-error at -2{{implicit declaration of function 'get_sub_group_size' is invalid in OpenCL}}
+// expected-error at -3{{implicit conversion changes signedness: 'int' to 'uint' (aka 'unsigned int')}}
 #endif
----------------
svenvh wrote:
> Anastasia wrote:
> > I am slightly confused about this error, isn't `get_sub_group_size` supposed to return uint?
> I think this is a side-effect from the previous error.  It failed to resolve `get_sub_group_size` so it inserted a placeholder declaration with return type `int`.  Does that make sense?
Ok, yes it's possibly a misparsing issue! Thanks!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67714/new/

https://reviews.llvm.org/D67714