[PATCH] D67826: [clangd] A helper to find explicit references and their names

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 24 05:49:10 PDT 2019


ilya-biryukov updated this revision to Diff 221522.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.

- Use DeclRefExpr::getFoundDecl, add a test
- Update a comment
- Remove redundant anon namespace declaration
- Remove :wa
- Do not filter-out macro references
- Document why we drop references with invalid locations, log if that happens
- Rename NextOffset to NextCodeChar


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67826/new/

https://reviews.llvm.org/D67826

Files:
  clang-tools-extra/clangd/FindTarget.cpp
  clang-tools-extra/clangd/FindTarget.h
  clang-tools-extra/clangd/unittests/FindTargetTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67826.221522.patch
Type: text/x-patch
Size: 22235 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190924/37038b4d/attachment-0001.bin>


More information about the cfe-commits mailing list