[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 23 15:33:14 PDT 2019


Eugene.Zelenko added inline comments.


================
Comment at: docs/clang-tidy/checks/objc-avoid-osread.rst:26
+
+The OSRead* functions from libkern/OSByteOrder.h have undocumented dependencies on aligned reads due to type punning by casting through a pointer:
+
----------------
Please highlight OSRead* and libkern/OSByteOrder.h with double back-ticks. Please also make lines no more then 80 characters long.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67865/new/

https://reviews.llvm.org/D67865





More information about the cfe-commits mailing list