[PATCH] D67826: [clangd] A helper to find explicit references and their names

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 23 06:56:04 PDT 2019


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/FindTarget.h:93
+  /// in 'obj.foo'.
+  const Expr* MemberExprBase = nullptr;
+};
----------------
do we have any real use-case for this field? apart from "skipping instance members in define inline"? because that one can also be achieved easily through decl (there is a `isCXXInstanceMember`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67826/new/

https://reviews.llvm.org/D67826





More information about the cfe-commits mailing list