[PATCH] D67633: [libTooling] Add `access` and `ifBound` combinators to Stencil library.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 23 06:15:43 PDT 2019


ymandel marked 3 inline comments as done.
ymandel added a comment.

Thanks for the review!



================
Comment at: clang/lib/Tooling/Refactoring/Stencil.cpp:195
+using AccessOp = StencilPartImpl<AccessData>;
+using IfBoundOp = StencilPartImpl<IfBoundData>;
 } // namespace
----------------
gribozavr wrote:
> These type aliases are only used once. Consider un-typealiasing.
Removed all of the aliases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67633/new/

https://reviews.llvm.org/D67633





More information about the cfe-commits mailing list