[PATCH] D67897: Fix __is_signed builtin
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Sep 22 22:58:11 PDT 2019
rsmith added a comment.
Thanks!
================
Comment at: clang/docs/LanguageExtensions.rst:1165
Note that this currently returns true for enumeration types if the underlying
- type is signed, and returns false for floating-point types, in violation of
- the requirements for ``std::is_signed``. This behavior is likely to change in
- a future version of Clang.
+ type is signed, and returns true for floating-point types.
* ``__is_standard_layout`` (C++, GNU, Microsoft, Embarcadero)
----------------
rsmith wrote:
> I'd just drop the second half of this sentence, and keep the "likely to change" warning for the non-conformance for enumeration types until that's fixed. (We already have an introductory sentence that says we follow the standard-specified behavior for traits marked (C++) unless otherwise specified.)
Now that this does the standard thing, you can delete this text entirely, or add a "before Clang 10, returned true for enumeration types if the underlying type was signed, and returned false for floating-point types".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67897/new/
https://reviews.llvm.org/D67897
More information about the cfe-commits
mailing list