[PATCH] D67897: Fix __is_signed builtin

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 22 17:16:10 PDT 2019


Quuxplusone added a comment.

In D67897#1678392 <https://reviews.llvm.org/D67897#1678392>, @rsmith wrote:

> In D67897#1678388 <https://reviews.llvm.org/D67897#1678388>, @Quuxplusone wrote:
>
> > But `std::is_signed_v<float>` needs to yield `false`.
>
>
> It should yield `true`; the spec says "If is_­arithmetic_­v<T> is true, the same result as T(-1) < T(0); otherwise, false".


Whoops! Never mind me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67897/new/

https://reviews.llvm.org/D67897





More information about the cfe-commits mailing list