[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 22 00:27:38 PDT 2019


plotfi marked an inline comment as done.
plotfi added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:15
+
+void tools::ifstool::Merger::ConstructJob(Compilation &C, const JobAction &JA,
+                                          const InputInfo &Output,
----------------
compnerd wrote:
> Why not:
> 
> ```
> namespace tools {
> namespace ifstool {
> ```
I could do that, but it would have to be:
```

namespace clang {
namespace driver {
namespace tools {
namespace ifstool {
...
} // namespace ifstool
} // namespace tools
} // namespace driver
} // namespace clang
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63978/new/

https://reviews.llvm.org/D63978





More information about the cfe-commits mailing list