[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 21 05:33:13 PDT 2019


Tyker marked 2 inline comments as done.
Tyker added inline comments.


================
Comment at: clang/lib/AST/APValue.cpp:176
+      (DataSize - sizeof(MemberPointerBase)) / sizeof(CXXRecordDecl *);
+  typedef CXXRecordDecl *PathElem;
   union {
----------------
Tyker wrote:
> aaron.ballman wrote:
> > Why is this no longer a pointer to `const`?
> when imporing or deserializing, we reserve the space for elements and then import/deserialize element directly in place. so the buffer storing them is not const. that said i saw that the normal construction cast away the const.
never mind this change wasn't needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63640/new/

https://reviews.llvm.org/D63640





More information about the cfe-commits mailing list