[PATCH] D67621: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 20 09:36:07 PDT 2019


ymandel added inline comments.


================
Comment at: clang/lib/Tooling/Refactoring/RangeSelector.cpp:320
+  };
+}
----------------
gribozavr wrote:
> May I ask to keep the implementation order consistent with the header file?
Moved the decl in the header to match the ordering in the implementation, which results in a better grouping (in terms of the signature and semantics of the combinators).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67621/new/

https://reviews.llvm.org/D67621





More information about the cfe-commits mailing list