[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

Nicholas Allegra via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 19 17:42:46 PDT 2019


comex updated this revision to Diff 220926.
comex added a comment.

In D67647#1674795 <https://reviews.llvm.org/D67647#1674795>, @dblaikie wrote:

> Right - I was suggesting that could be changed. Would it be OK to you to change arguments() to return ArrayRef? Or would you rather avoid that to avoid baking in more dependence on that alias violation?


I'd rather avoid that for the reason you said.

> Same reason I've pushed back on adding things like "empty()" or "size()", etc. Which are fine (& have been added in STLExtras) as free functions.

Okay, I'll just do that then.  Added as `index(Range, N)`, matching range-v3 (though not the actual C++20 draft).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67647/new/

https://reviews.llvm.org/D67647

Files:
  clang/include/clang/AST/Stmt.h
  clang/lib/Analysis/Consumed.cpp
  llvm/include/llvm/ADT/STLExtras.h
  llvm/include/llvm/ADT/iterator_range.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67647.220926.patch
Type: text/x-patch
Size: 6830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190920/155dc997/attachment-0001.bin>


More information about the cfe-commits mailing list