[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 19 14:06:12 PDT 2019


tra added inline comments.


================
Comment at: lib/Sema/SemaCUDA.cpp:386-387
+  bool NeedsH = true, NeedsD = true;
+  bool HasH = MemberDecl->hasAttr<CUDAHostAttr>();
+  bool HasD = MemberDecl->hasAttr<CUDADeviceAttr>();
+
----------------
Nice.
Now these can be moved above `HasExpAttr` and then used in its initializer to make it shorter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67509/new/

https://reviews.llvm.org/D67509





More information about the cfe-commits mailing list