[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

Thu Sep 19 00:48:20 PDT 2019

stephanemoore marked 4 inline comments as done.
stephanemoore added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:40
+void MissingHashCheck::registerMatchers(MatchFinder *Finder) {
+  Finder->addMatcher(
+      objcMethodDecl(
----------------
Eugene.Zelenko wrote:
> Should check if language is Objective-C. See ForbiddenSubclassingCheck.cpp as example. Will be good ensure that all Objective-C checks do this.
Thanks for calling this out; I tried using the check addition script and forgot to include this important conditional. I believe this has been resolved with my proposed changes.

================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:105

+- New :doc:`objc-missing-hash
+  <clang-tidy/checks/objc-missing-hash>` check.
----------------
Eugene.Zelenko wrote:
> Wrong place. Please move to new checks list (in alphabetical order).
Thanks for pointing this out. I believe I may have made an error while resolving merge conflicts. I believe this has now been resolved.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67737/new/

https://reviews.llvm.org/D67737