[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus added a comment.

We have no solid evidence to conclude that such an event should not occur at a `BlockEntrance`, so fixing this error mustn't be that bad. I certainly should've used `llvm::isa_or_nonnull`, so the patch overall makes sense, so I'm commiting it as is. With that said, this test case highlights a fundamental flaw in how loop wideining is implemented (hence it being off-by-default), and it should be addressed later separately.

I have talked to @NoQ about this behind the scenes, which is why I'm not concerned with the green check mark :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66716/new/

https://reviews.llvm.org/D66716