[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 18 12:17:49 PDT 2019


dblaikie added a comment.

In D67647#1673363 <https://reviews.llvm.org/D67647#1673363>, @comex wrote:

> Ugh, it looks like `getArgs()` is a massive strict aliasing violation.  And it's used in enough different places in Clang that fixing the violation may require extensive refactoring... I've reported the issue as https://bugs.llvm.org/show_bug.cgi?id=43344, but I don't really want to fix it :)
>
> However, I can at least update this patch to avoid using getArgs().


Yeah, existing technical debt - I don't think your situation is making that any worse or better, so no worries about it.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67647/new/

https://reviews.llvm.org/D67647





More information about the cfe-commits mailing list