[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI
Alexander Richardson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 18 10:49:16 PDT 2019
arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.
Looks good to me but I guess someone else should give the final approval.
================
Comment at: llvm/lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp:25
if (TheTriple.isMIPS64() && TheTriple.getEnvironment() != Triple::GNUABIN32)
CodePointerSize = CalleeSaveStackSlotSize = 8;
----------------
Unrelated to this diff, but I guess this Triple environment check should be moved down and use `ABI.isN32()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66795/new/
https://reviews.llvm.org/D66795
More information about the cfe-commits
mailing list